Test run: Avoid collector hanging when interrupted via CTRL+C (SIGINT) #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way the signal handling is written, we stop checking the testRunSuccess channel once a SIGINT is received. However the code that marks the wait groups as done could only return once it finished writing to the channel, since it was unbuffered. Make the channel buffered so that the code can return as intended. Fixes #561
msakrejda
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the signal handling is written, we stop checking the testRunSuccess channel once a SIGINT is received. However the code that marks the wait groups as done could only return once it finished writing to the channel, since it was unbuffered. Make the channel buffered so that the code can return as intended.
Fixes #561