Query runner: Block known problematic functions if found in parse tree #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This acts as an additional defense in case the user does not revoke permissions from non-superuser for dblink as we recommend.
keiko713
reviewed
Jan 7, 2025
msakrejda
approved these changes
Jan 7, 2025
keiko713
reviewed
Jan 7, 2025
| switch stmt.(type) { | ||
| case *pg_query.Node_SelectStmt: | ||
| // Allowed, continue | ||
| // Note that we permit wCTEs here (for now), and instead rely on the read-only transaction to block them |
There was a problem hiding this comment.
Talked a bit offline too, but we could potentially do these checks in the below treewalk so that we can also check wCTEs. I think it's fine as is for now, but we could come back later potentially.
There was a problem hiding this comment.
Yeah, lets revise that at a later point, but agreed we could adjust this to match the check we do on the server side for wCTEs.
keiko713
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This acts as an additional defense in case the user does not revoke permissions from non-superuser for dblink as we recommend.