Support passing parse mode to parse/fingerprint functions #216
Conversation
Added parseMode to json output for PLpgSQL_expr struct
|
Mainly commenting so I don't forget: For the newly introduced Need to think through this more how it could be part of the API, but might be worth doing now so we don't have to break the |
Most importantly, this allows turning off standard_conforming_strings to support legacy applications. It also adds support for turning off backslash_quote and escape_string_warning. These settings can be set by passing the following flags to the _opts function variants. Use bitwise OR to combine flags, as well as set the parse mode. - PG_QUERY_DISABLE_BACKSLASH_QUOTE (backslash_quote = off) - PG_QUERY_DISABLE_STANDARD_CONFORMING_STRINGS (standard_conforming_strings = off) - PG_QUERY_DISABLE_ESCAPE_STRING_WARNING (escape_string_warning = off) Fixes pganalyze#50
I've gone ahead and done that change now on this branch (thanks for allowing maintainer edits!), by utilizing an integer as a bitmask instead of a simple enum. From a usability perspective this is essentially the same as if you just care about the parse mode, but if you want to set the options you can just use bitwise OR to enable them. Overall I think I'm happy with this now. @seanlinsley might be worth if you take another look to see if there are any concerns with that last commit, but otherwise I think we can merge. |
|
@lcheruka Thanks for the contribution! Merged with slight revisions to allow passing additional options beyond the parse mode. |
Fixes #215