-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New covergen tool #44
Conversation
TODO:
|
I've tested this, and it works well on my Mini and Aura2v1. For epubs, it now shows the actual cover instead of a screenshot of the first page with a black border. For kepubs, it now consistently shows the cover image, even for books without the cover-image property or the meta tag. There also isn't an extra black border around the covers anymore either, and the cover fills the space properly. I've checked it on the view details, the home screen, the sleep screen, the library list, and the library grid. To regenerate the covers from nothing, it seems to be just under twice as fast as the built-in cover generation. P.S. One slightly unrelated thing I noticed is that nickel seems to like segfaulting if you delete .kobo-images from under it and have PDF books. This still needs to be tested on Windows to make sure the path handling is correct. I'd also appreciate it if someone with a Libra and a wide variety of books could test this out (use the |
I've added an option to set the aspect ratio of the covers. I personally like 1.5, but 1.6 fills the space on the home screen better (but it looks too stretched to me). |
Do you have any plans to support PNG and/or SVG (input) cover images? |
Yes, PNG and GIF are supported right now (in terms of the format itself), but for the color encoding, I'll need to add conversion so rez can use it. I'm not planning to add SVG at the moment, though. |
Ah yes. See that now. Was looking at the resize code, which only deals with YCbCr colourspace. |
BTW: I'm happy for you to re-license any of the image code from KU if you wish. By this point, it's mostly all your code anyway :p Main reason for using AGPL3 in KU is because of FBInk. And FBInk has been re-licensed to plain GPL now, so I can probably change KU. |
I was considering switching resize libraries, as all are pretty fast on x86, but then I realized some of my scripts run kepubify and seriesmeta on the Kobo itself. I also don't want to pull in too many dependencies.
Yes, at first I did pull it from KU, but I realized since I was re-doing the research again, I might as well write it from scratch. |
I've just tested this while setting up my Clara, and it worked perfectly and resulted in a huge performance benefit to looking through the library. I'm going to merge it and make a release once I merge the koboutils PR. |
cc @shermp @NiLuJe