Skip to content

Commit

Permalink
Fix heirloom journal error
Browse files Browse the repository at this point in the history
  • Loading branch information
Phanx committed Jul 25, 2016
1 parent 0c78ab2 commit fd33688
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 129 deletions.
2 changes: 2 additions & 0 deletions !ClassColors.toc
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
## X-CompatibleLocales: enUS, deDE, esES, esMX, frFR, itIT, koKR, ptBR, ruRU, zhCN, zhTW
## X-Localizations: enUS, deDE, esES, esMX, ptBR, ruRU
## X-Website: https://github.com/Phanx/ClassColors
## X-Curse-Project-ID: classcolors
## X-WoWI-ID: 12513

## SavedVariables: ClassColorsDB

Expand Down
119 changes: 4 additions & 115 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,118 +1,7 @@
### Version 7.0.3.0

* Updated for WoW 7.0 (Legion)

### Version 6.2.2.0

* Updated for WoW 6.2.2
* Added coloring for heirloom journal class filter dropdown
* Added coloring for loot recipients in the boss banner frame

### Version 6.0.3.24

* Fixed coloring on the character frame level text
* Added a workaround for some addons passing invalid GUIDs to GetColoredName

### Version 6.0.3.23

* Updated for Warlords of Draenor

### Version 5.4.8.101

* Added Russian translations from Yafis

### Version 5.4.7.94

* Updated chat player name coloring for realm name changes in WoW 5.4.7

### Version 5.4.2.90

* Added a NotifyChanges method for addons that provide their own class color options UI, but not their own CUSTOM_CLASS_COLORS implementation, and want to propigate their changes to other addons through the CUSTOM_CLASS_COLORS system.
* Added support for female-specific class names to the GetClassToken method, though I suspect nobody has ever actually used this method.

### Version 5.4.2.88

* Fixed an issue preventing player specialization names from appearing the inspect frame

### Version 5.4.1.87

* Fixed an error on the PTR caused by Blizzard fixing a typo in a function name

### Version 5.4.1.86

* Updated for WoW 5.4
* Fixed coloring in the LFG cooldown list

### Version 5.3.0.83

* Updated for WoW 5.3
* Fixed coloring in Challenge Mode best times tooltips

### Version 5.2.0.80

* Updated for WoW 5.2

### Version 5.1.0.78
### Version 7.0.3.1

* Updated for WoW 5.1
- Fixed an error when opening or changing the class filter in the heirloom journal

### Version 5.0.4.76

* Updated for WoW 5.0.4
* Added better compatibility with other implementations of CUSTOM_CLASS_COLORS

### Version 4.3.4.56

* Raid and party member blips on the world map will now be recolored using your custom colors.
* *Due to Blizzard restrictions, it is **not** possible to recolor blips on the minimap.*
* Added Português (ptBR) localization.

### Version 4.2.0.51

* Updated for WoW 4.2

### Version 4.1.0.49

* Updated for WoW 4.1
* Removed the IterateClasses metamethod since nobody uses it
* Changed the GetColoredName override to more closely emulate the original Blizzard function, as requested by Funkydude on WowAce

### Version 4.0.3.43

* Fixed LFR browser and who list coloring

### Version 4.0.3.40

* Fixed raid panel coloring

### Version 4.0.1.36

* Someday I will remember to turn off debugging before posting a release...

### Version 4.0.1.35

* Updated Blizzard UI coloring for WoW 4.0

### Version 4.0.1.33

* Removed a function that no longer exists in WoW 4.0
* Guild panel coloring hasn't been updated yet

### Version 3.3.3.29

* Player names in the raid panel will now always be colored correctly
* Added additional checks to prevent GetPlayerInfoByGUID usage errors

### Version 3.3.0.26

* Added coloring of class names in the channel pane of the chat config window

### Version 3.3.0.24

* Added coloring of names in the LookingForRaid interface
* Fixed drycode errors

### Version 3.3.0.22
### Version 7.0.3.0

* Updated for WoW 3.3
* Removed coloring for parts of the UI that aren't normally colored. This functionality may or may not reappear in a separate addon at a later date.
- Updated for WoW 7.0 (Legion)
32 changes: 18 additions & 14 deletions ClassColorsBlizz.lua
Original file line number Diff line number Diff line change
Expand Up @@ -508,21 +508,25 @@ end
-- Blizzard_HeirloomCollection.lua

addonFuncs["Blizzard_Collections"] = function()
local NO_CLASS_FILTER = 0
local NO_SPEC_FILTER = 0

function HeirloomsJournal:UpdateClassFilterDropDownText()
local text
if self.classFilter == 0 then -- NO_CLASS_FILTER
text = ALL_CLASSES
else
local className, classTag = GetClassInfoByID(self.classFilter)
local classColorStr = CUSTOM_CLASS_COLORS[classTag].colorStr -- CHANGED
if self.specFilter == 0 then -- NO_SPEC_FILTER
text = HEIRLOOMS_CLASS_FILTER_FORMAT:format(classColorStr, className)
else
local specName = GetSpecializationNameForSpecID(self.specFilter)
text = HEIRLOOMS_CLASS_SPEC_FILTER_FORMAT:format(classColorStr, className, specName)
end
end
UIDropDownMenu_SetText(self.classDropDown, text)
local text;
local classFilter, specFilter = C_Heirloom.GetClassAndSpecFilters()
if classFilter == NO_CLASS_FILTER then
text = ALL_CLASSES
else
local className, classTag = GetClassInfoByID(classFilter)
local classColorStr = CUSTOM_CLASS_COLORS[classTag].colorStr
if specFilter == NO_SPEC_FILTER then
text = HEIRLOOMS_CLASS_FILTER_FORMAT:format(classColorStr, className)
else
local specName = GetSpecializationNameForSpecID(specFilter)
text = HEIRLOOMS_CLASS_SPEC_FILTER_FORMAT:format(classColorStr, className, specName)
end
end
UIDropDownMenu_SetText(self.classDropDown, text)
end
end

Expand Down

0 comments on commit fd33688

Please sign in to comment.