Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate dependencies #613

Closed
wants to merge 2 commits into from
Closed

Conversation

Jeff-Thompson12
Copy link
Collaborator

No description provided.

@Jeff-Thompson12 Jeff-Thompson12 changed the base branch from master to dev August 14, 2023 13:00
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #613 (2f143ab) into dev (f9dc187) will decrease coverage by 0.06%.
Report is 1 commits behind head on dev.
The diff coverage is 0.00%.

❗ Current head 2f143ab differs from pull request most recent head 85f6437. Consider uploading reports for the commit 85f6437 to get more accurate results

@@            Coverage Diff             @@
##              dev     #613      +/-   ##
==========================================
- Coverage   77.12%   77.07%   -0.06%     
==========================================
  Files          29       29              
  Lines        3869     3869              
==========================================
- Hits         2984     2982       -2     
- Misses        885      887       +2     
Files Changed Coverage Δ
R/mod_packageDependencies.R 18.37% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jeff-Thompson12
Copy link
Collaborator Author

Choosing not to update NEWS because this fix is being pushed to master as well

@Jeff-Thompson12 Jeff-Thompson12 marked this pull request as ready for review August 14, 2023 14:03
@AARON-CLARK
Copy link
Collaborator

I don't think this PR is necessary, is it? I would think merging master into dev would suffice, no?

@Robert-Krajcik
Copy link
Contributor

FYI I just opened an issue #615 Seeing double on some package dependencies

@AARON-CLARK AARON-CLARK marked this pull request as draft August 15, 2023 01:18
@AARON-CLARK AARON-CLARK deleted the jt-fix-duplicate-dependencies branch August 17, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants