Add filter for database overview

[Eduardodudu]

Task

Feature task on the option to upload all packages #586

This PR adds

1. Adds a filter on top of the table for database overview

[AARON-CLARK]

Sorry @Eduardodudu, I saw this PR marked as "Draft" so I thought it was still under development. I see now that you requested my review several months ago. I pushed a couple commits to update your branch. We'll see how the CI checks fair.

[AARON-CLARK]

@Eduardodudu, I also pushed a few commits to change the aesthetics of the filters. Previously, they were pretty large, using bootstrap styles. I converted to a more "plain" / minimalist look that takes up less visual real estate:

In addition, I'm wondering if you could explore one more thing. Right now, we've been converting everything to character so that we can manipulate how blank cells look. AKA, we've replaced NAs and empty chars ("") with "-". As a result, this holds us back from leveraging the cool filtering widgets that come by default with DT's filter, as seen below. There are range sliders for dates and numeric values, which would come in handy. Also, factor variables get a handy dropdown menu of values to choose from, which would be useful for decision and decision_by columns. I've pushed a commit to restore these data types.However, it looks like it still doesn't work unless we remove the formattable::as.datatable(formattable::formattable()) code, which adds a lot value to our score, decision, and explore metrics columns.

Wondering if we can somehow maintain the {formattable} code AND still leverage the handy filtering widgets?

[AARON-CLARK]

Hey @Jeff-Thompson12, I'm getting pulled to another project for the next few days. Wondering if you can help resolve these broken tests before the new release?

[Jeff-Thompson12]

Yeah, I got you bro

[codecov]

Codecov Report

Merging #619 (ba5e4d9) into dev (964faed) will increase coverage by 0.04%.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head ba5e4d9 differs from pull request most recent head 1de5f6f. Consider uploading reports for the commit 1de5f6f to get more accurate results

@@            Coverage Diff             @@
##              dev     #619      +/-   ##
==========================================
+ Coverage   72.88%   72.93%   +0.04%     
==========================================
  Files          33       33              
  Lines        4762     4770       +8     
==========================================
+ Hits         3471     3479       +8     
  Misses       1291     1291              

Files	Coverage Δ
R/mod_databaseView.R	91.47% <100.00%> (+0.40%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AARON-CLARK]

Hi @Robert-Krajcik, since Jeff and I both pushed commits to this branch, wondering if you could provide the final review?

[Robert-Krajcik]

Hi @AARON-CLARK Sure.

[Robert-Krajcik]

Hi @AARON-CLARK and @Jeff-Thompson12
The basic filtering works. For me, everything to the right of score is greyed out, probably because I haven't populated it.
Not sure filtering on explore metrics makes sense, but I assume it's always greyed out.

Just wondering if we could do something with the score, like allowing a range of values, or even "<" or ">"?

[AARON-CLARK]

... everything to the right of score is greyed out, probably because I haven't populated it.

Whenever a column is populated with the a constant value, DT is smart enough to know that there is no variability and filtering is pointless.

Not sure filtering on explore metrics makes sense, but I assume it's always greyed out.

It is, I added a little code to make sure the last column's filtering widget was disabled.

Just wondering if we could do something with the score, like allowing a range of values, or even "<" or ">"?

Right now, DT does offer a range slider for numeric variables, but it's not showing up because we're using formattable::as.datatable() instead of DT::datatable(). Creating a workaround is going to make a little too much extra work, so we are going to leave things as-is for this PR.

Thanks @Robert-Krajcik! If everything else looks okay, feel free to merge.

[Robert-Krajcik]

Looks good to me!

[Eduardodudu]

Hey @AARON-CLARK!

Sorry for the late response, I was on vacation

I see that the task is already closed.

Thanks for the return @AARON-CLARK !