Rk 621 comm metric fix

[Robert-Krajcik]

Addresses issue #621

Looks like the initialize_metric_table.sql had already been updated.
The "Package Downloads" card is no longer flagged as non-metric

But the metric table in upload_format.database needs updating.

[codecov]

Codecov Report

Merging #622 (229cb78) into dev (60f0c0c) will decrease coverage by 0.11%.
Report is 1 commits behind head on dev.
The diff coverage is n/a.

❗ Current head 229cb78 differs from pull request most recent head f736cf9. Consider uploading reports for the commit f736cf9 to get more accurate results

@@            Coverage Diff             @@
##              dev     #622      +/-   ##
==========================================
- Coverage   76.44%   76.34%   -0.11%     
==========================================
  Files          29       29              
  Lines        3919     3919              
==========================================
- Hits         2996     2992       -4     
- Misses        923      927       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Robert-Krajcik]

code used to update (and verify) the metric table

test_db_loc <- system.file("testdata", "upload_format.database", package = "riskassessment")
dbSelect("select * from metric ", test_db_loc)

dbUpdate("drop table metric", test_db_loc)
src_code <- readLines(system.file("sql_queries", "create_metric_table.sql", package = "riskassessment"), warn = FALSE)
sql_code <- paste(src_code, collapse = " ")
dbUpdate(sql_code, test_db_loc)
src_code <- readLines(system.file("sql_queries", "initialize_metric_table.sql", package = "riskassessment"), warn = FALSE)
sql_code <- paste(src_code, collapse = " ")
dbUpdate(sql_code, test_db_loc)

dbSelect("select * from metric ", test_db_loc)

[AARON-CLARK]

Looks good Robert. I just made a few comments below. Could you also increment the dev version? Thanks!

[Robert-Krajcik]

I had noticed the weight for covr_coverage was = 1 in the upload_format_database metric table
code used to correct it:

test_db_loc <- system.file("testdata", "upload_format.database", package = "riskassessment")
dbUpdate("update metric set weight = 0 where name = 'covr_coverage'", test_db_loc)
target <- dbSelect("select * from metric", test_db_loc)
compar <- dbSelect("select * from metric", "database.sqlite")
all.equal(target, compar)

[AARON-CLARK]

👍🏼 Looks great!