Dependency "Upload All" follow up#626

[Eduardodudu]

Task

Feature task on the option to hide upload all packages when there is no package to be shown in table #626

This PR adds

1. Checks if there are packages to be rendered on the table and only shows upload all option when it does

[codecov]

Codecov Report

Merging #628 (995f766) into dev (60f0c0c) will increase coverage by 0.19%.
Report is 14 commits behind head on dev.
The diff coverage is 14.81%.

❗ Current head 995f766 differs from pull request most recent head 0679c75. Consider uploading reports for the commit 0679c75 to get more accurate results

@@            Coverage Diff             @@
##              dev     #628      +/-   ##
==========================================
+ Coverage   76.44%   76.64%   +0.19%     
==========================================
  Files          29       29              
  Lines        3919     3917       -2     
==========================================
+ Hits         2996     3002       +6     
+ Misses        923      915       -8     

Files Changed	Coverage Δ
R/mod_packageDependencies.R	18.66% <14.81%> (+2.80%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AARON-CLARK]

Hi @Eduardodudu, I know I didn't specify this request in the #626, but I think it'd also be valuable to have the "Upload All" button be hidden when there are no packages to upload too (see use case below). To me, it makes sense to tackle this change in this PR since it's highly related to checking for rows in the table and you already wrote the logic in #616. Specifically, your authored this logic which is very handy:

riskassessment/R/mod_packageDependencies.R

Lines 338 to 343 in 744be35

	pkgs_update <- pkg_df() %>%
	dplyr::filter(is.na(score) | score == "") %>%
	dplyr::filter(!name %in% c(rownames(installed.packages(priority = "base"))))
	n_packages <- nrow(pkgs_update)
	if (n_packages > 0) {

Here is a use case. I already have the zoo package uploaded, so I don't need the option to "Upload All":

[Eduardodudu]

Hi @Eduardodudu, I know I didn't specify this request in the #626, but I think it'd also be valuable to have the "Upload All" button be hidden when there are no packages to upload too (see use case below). To me, it makes sense to tackle this change in this PR since it's highly related to checking for rows in the table and you already wrote the logic in #616. Specifically, your authored this logic which is very handy:

riskassessment/R/mod_packageDependencies.R

Lines 338 to 343 in 744be35

	pkgs_update <- pkg_df() %>%
	dplyr::filter(is.na(score) | score == "") %>%
	dplyr::filter(!name %in% c(rownames(installed.packages(priority = "base"))))
	n_packages <- nrow(pkgs_update)
	if (n_packages > 0) {

Here is a use case. I already have the zoo package uploaded, so I don't need the option to "Upload All":

Hi @AARON-CLARK!

I actually enjoyed a lot this idea!

Right now the app will only show "Upload All" Icon when there is actually a package to be uploaded.

[AARON-CLARK]

Looks good to me!