Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autonavigation #779

Merged
merged 21 commits into from
Jul 8, 2024
Merged

Autonavigation #779

merged 21 commits into from
Jul 8, 2024

Conversation

narayanan-iyer-pfizer
Copy link
Collaborator

This addresses #644 and adds new buttons

@narayanan-iyer-pfizer narayanan-iyer-pfizer linked an issue May 14, 2024 that may be closed by this pull request
@narayanan-iyer-pfizer narayanan-iyer-pfizer marked this pull request as ready for review May 14, 2024 16:55
@aclark02-arcus aclark02-arcus changed the base branch from master to dev May 14, 2024 17:00
@jthompson-arcus jthompson-arcus requested review from jthompson-arcus and removed request for jthompson-arcus May 14, 2024 19:35
Copy link
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narayanan-iyer-pfizer thanks for working on this. The feature is not working for me. Didn't dig too deep into why that was the case. The JavaScript does not appear to be functioning as intended though.

I'm not a huge fan of how the buttons look. I think personally I would want something more minimal. Could a count also be included (e.g. < 1 of 3 >)? I think that would add a lot.

R/mod_code_explorer.R Show resolved Hide resolved
@jthompson-arcus jthompson-arcus changed the base branch from dev to master June 12, 2024 12:29
@jthompson-arcus jthompson-arcus changed the base branch from master to dev June 12, 2024 12:29
@jthompson-arcus jthompson-arcus self-requested a review June 12, 2024 12:29
@jthompson-arcus
Copy link
Collaborator

@narayanan-iyer-pfizer I started looking at this again and then realized you didn't re-request me to review. Did you want a review or are you still working?

@narayanan-iyer-pfizer
Copy link
Collaborator Author

@narayanan-iyer-pfizer I started looking at this again and then realized you didn't re-request me to review. Did you want a review or are you still working?

Please review it. I'm done with this

Merge branch 'dev' into ni-644-autonavigation

# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	manifest.json
Copy link
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narayanan-iyer-pfizer sorry for sitting on this review for so long.

In addition to the conversations below, I noticed that if you select the file type "Help Documentation" that the buttons stay visible for the last view.
image width="100%"

R/mod_code_explorer.R Show resolved Hide resolved
R/mod_code_explorer.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jthompson-arcus jthompson-arcus merged commit 10690d0 into dev Jul 8, 2024
1 check passed
@jthompson-arcus jthompson-arcus deleted the ni-644-autonavigation branch July 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function Explorer: Auto navigation to highlighted rows
3 participants