-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autonavigation #779
Autonavigation #779
Conversation
…skassessment into ni-644-autonavigation
Add navigation controls to function explorer tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narayanan-iyer-pfizer thanks for working on this. The feature is not working for me. Didn't dig too deep into why that was the case. The JavaScript does not appear to be functioning as intended though.
I'm not a huge fan of how the buttons look. I think personally I would want something more minimal. Could a count also be included (e.g. < 1 of 3 >)? I think that would add a lot.
Add navigation controls to function explorer tab
…skassessment into ni-644-autonavigation
@narayanan-iyer-pfizer I started looking at this again and then realized you didn't re-request me to review. Did you want a review or are you still working? |
Please review it. I'm done with this |
Merge branch 'dev' into ni-644-autonavigation # Conflicts: # DESCRIPTION # NEWS.md # manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narayanan-iyer-pfizer sorry for sitting on this review for so long.
In addition to the conversations below, I noticed that if you select the file type "Help Documentation" that the buttons stay visible for the last view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This addresses #644 and adds new buttons