-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Decision
col to Pkg Dependency table
#784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both stats would be useful to know. So I need |
That makes sense to me. We have so much logic in the app that assumes an ordering to the decision categories anyways. I think it's natural to assume that even if an org wants additional categories for workflow purposes, those could be housed between the reject/accept decisions. |
@jthompson-arcus: updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Dependencies Tab. AND remove 'NA's from decision column on pdf reports.
Fixed @jthompson-arcus! However, this is still showing up:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console warning is related to get_text_color()
function. It is expecting a single value but getting a list. It also shows up when viewing the database viewer. I will push a fix in a separate PR.
Seeks to close the first part of #774 with a start of adding the
Decision
column to the pkg dependency tables. Recall, there are three spots this table shows up: the pkg dep module, the report preview mod, and the reports themselves.I think everything is kosher, and I even managed to enhance the "build report", which previously wasn't rendering the
score
anddecision
fields with color. It appears to be a little tricker to do this on the HTML reports, so I didn't tackle it in this PR.Two pesky things I noticed in this PR is...
(1) that the menu won't disappear on the Build Report view:
(2) the console keeps showing this message when the pkg deps tab and build report tabs are opened: