Dep Card: Decision Summary #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ision_id & decsion variables
…nload handler and reportpreview mods
… on all other tibble() and as_tibble() calls.
jthompson-arcus
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Few things:
- I noticed that the red color when a dependency has a high decision doesn't show up on the HTML report. Is this intentional or an oversight?
- In the PDF report I didn't get the line break for the new card.
- Getting this warning in the console when "Include Suggests" is selected
aclark02-arcus
requested review from
jthompson-arcus
and removed request for
jthompson-arcus
|
@aclark02-arcus I found this issue on the dependency tab: Do you want to fix this here or do you want me to open a new issue for it after your PR is merged? Everything else is looking good. |
@jthompson-arcus, that works! |
jthompson-arcus
requested changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part II of a two part PR to close #774. It also updates that layout of the package dependencies tab (and reports) as well.
Some views of the new card:
When no high risk exists:
When there is any high risk package, the text and icon turn red:
When no decisions exist (or no dependencies)