Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: simplify global imports #187

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

m-kolomanski
Copy link
Collaborator

@m-kolomanski m-kolomanski commented Jan 31, 2025

Description

Simplifies import statements in global.R file. With this change, there is no need to explicitly import every module and function files. All .R files that are placed in modules/ and functions/ will be automatically sourced to the application.

How to test

Run the app, check if it works correctly.

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • Package version is incremented

@m-kolomanski m-kolomanski marked this pull request as ready for review January 31, 2025 11:59
Copy link
Collaborator

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a blank line at the end of global.R

Copy link
Collaborator

@js3110 js3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@m-kolomanski m-kolomanski merged commit f5d291a into main Feb 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants