Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #124 rs_ca125: add rs_onco_ca125 #131

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Closes #124 rs_ca125: add rs_onco_ca125 #131

merged 11 commits into from
Jan 15, 2025

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Dec 11, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Dec 11, 2024

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)

@bundfussr bundfussr changed the title 123 rs ca125 Closes #124 rs_ca125: add rs_onco_ca125 Dec 12, 2024
@starosto
Copy link

starosto commented Jan 9, 2025

Hi @vinhn23,

Below further potential issues in SUPPRS;
"01-701-1118" has CA125 responses SD, CR, NE, CR but in SUPPRS records with CA50RED=Y are assigned to SD, NE and CR.
"01-701-1133" has CA125 responses PR, PD, PD but in SUPPRS I do not see record with CA50RED for PR

I also face a problem while loading branch 123_rs_ca125, there is a message about ca125_rs.rda file:
Warning: file ‘ca125_rs.rda’ has magic number 'PK���'
Use of save versions prior to 2 is deprecated
Error in load(zfile, envir = tmp_env) :
bad restore file magic number (file may be corrupted) -- no data loaded
ERROR: lazydata failed for package ‘pharmaversesdtm’

Do you also face this problem? @bundfussr any suggestion?

@bundfussr
Copy link
Collaborator

Hi @vinhn23,

Below further potential issues in SUPPRS; "01-701-1118" has CA125 responses SD, CR, NE, CR but in SUPPRS records with CA50RED=Y are assigned to SD, NE and CR. "01-701-1133" has CA125 responses PR, PD, PD but in SUPPRS I do not see record with CA50RED for PR

I also face a problem while loading branch 123_rs_ca125, there is a message about ca125_rs.rda file: Warning: file ‘ca125_rs.rda’ has magic number 'PK���' Use of save versions prior to 2 is deprecated Error in load(zfile, envir = tmp_env) : bad restore file magic number (file may be corrupted) -- no data loaded ERROR: lazydata failed for package ‘pharmaversesdtm’

Do you also face this problem? @bundfussr any suggestion?

@starosto , yes, I'm facing the same problem. I assume the file was added by mistake. @vinhn23 , could you check?

@bundfussr
Copy link
Collaborator

@manciniedoardo , could you merge this PR?

I'm not authorized to merge. Is this intended?

@manciniedoardo
Copy link
Collaborator

@manciniedoardo , could you merge this PR?

I'm not authorized to merge. Is this intended?

It is not - i will fix that, for now i will merge.

@manciniedoardo manciniedoardo merged commit b0ba9ea into main Jan 15, 2025
16 checks passed
@manciniedoardo manciniedoardo deleted the 123_rs_ca125 branch January 15, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add RS/SUPPRS test data for Ovarian cancer ADRS vignette for {admiralonco}
5 participants