# 16 calculate_study_day

[yli110-stat697]

close #16

[github-actions]

Package	Line Rate	Health
sdtm.oak	86%	✔
Summary	86% (349 / 408)	✔

[yli110-stat697]

Hi @ShiyuC can you take a look at this design and see if it's okay? If so, I can start to add documentation and unit tests

[ShiyuC]

Hi @ShiyuC can you take a look at this design and see if it's okay? If so, I can start to add documentation and unit tests

@yli110-stat697 Hi Rosemary, thanks for creating this PR. It looks good to me. Feel free to move on with documentation and unit test at your convenience

[ShiyuC]

Hi @yli110-stat697! Could you create a test within the testthat folder so that we could run the function with your test? Thanks!

[yli110-stat697]

Hi @yli110-stat697! Could you create a test within the testthat folder so that we could run the function with your test? Thanks!

Hi yes I can, do we agree on the design already?

[ramiromagno]

EDIT, EDIT: Now that I've check how study day is calculated, I think it is actually simpler to implement. Please take a look at my commit.

Thanks @ramiromagno I think it looks good except that the condition should have equal sign. BTW, you can use "Suggest" functionality instead of pushing commit to show your suggestion. Developer can directly commit your "suggestion". Because forgetting to pull other people's commit usually causes merge conflict locally.

Hi @yli110-stat697 : Thanks for the tip. Will do next time (sorry for the inconvenience!).

[yli110-stat697]

Hi @galachad my pipeline failed due to pandoc installation error. I belive this has nothing to do with my code. How do I fix this?

[ShiyuC]

The MR looks good to me. Just commented on one small typo. Thanks @yli110-stat697 for all of your effort!

[ramiromagno]

Looks good to me.