Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdtm.oak SDTM spec, Algorithms Documentation and template r code for cm domain #30

Merged
merged 23 commits into from
Jan 31, 2024

Automatic renv profile update.

a226175
Select commit
Loading
Failed to load commit list.
Merged

sdtm.oak SDTM spec, Algorithms Documentation and template r code for cm domain #30

Automatic renv profile update.
a226175
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jan 31, 2024 in 0s

14 / 14 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Place Closes #17 into the beginning of your Pull z
Request Title (Use Edit button in top-right if you need to update) Completed
Code is formatted according to the
tidyverse style guide. Run
styler::style_file() to style R and Rmd files Completed
Updated relevant unit tests or have written new unit tests, which should
consider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide Completed
If you removed/replaced any function and/or function parameters, did you
fully follow the
deprecation guidance? Completed
Update to all relevant roxygen headers and examples, including keywords
and families. Refer to the
categorization of functions to tag appropriate keyword/family. Completed
Run devtools::document() so all .Rd files in the man folder and the
NAMESPACE file in the project root are updated appropriately Completed
Address any updates needed for vignettes and/or templates Completed
Update NEWS.md if the changes pertain to a user-facing function (i.e. it
has an @export tag) or documentation aimed at users (rather than developers) Completed
Build oak site pkgdown::build_site() and check that all affected
examples are displayed correctly and that all new functions occur on the "Reference" page. Completed
Address or fix all lintr warnings and errors - lintr::lint_package() Completed
Run R CMD check locally and address all errors and warnings - devtools::check() Completed
Link the issue in the Development Section on the right hand side. Completed
Address all merge conflicts and resolve appropriately Completed
Pat yourself on the back for a job well done! Much love to your accomplishment! Completed
Introduce "Good for Start" Tag: Consider adding a "good for start" label to certain GitHub issues. This would help new contributors easily identify beginner-friendly tasks, providing a clear entry point into the project. Incomplete
Encourage PR Reviews and Documentation Contributions: Newcomers could also begin by reviewing existing PRs and contributing to documentation. This approach offers a great way to understand the project's standards and codebase without requiring deep initial knowledge. Incomplete