Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies and fix documentation #71

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Cleanup dependencies and fix documentation #71

merged 3 commits into from
Jul 24, 2024

Conversation

galachad
Copy link
Member

@galachad galachad commented Jul 23, 2024 •
edited
Loading

  • Documentation fix
  • Replace glue with stringr str_glue
  • Move DT, readr to suggest
  • Replace readr with R base functionalities

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
sdtm.oak 88% ✔
Summary 88% (902 / 1022) ✔

edgar-manukyan
edgar-manukyan approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@edgar-manukyan edgar-manukyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam, LGTM.

@galachad galachad merged commit bdbafc9 into main Jul 24, 2024
15 checks passed
@galachad galachad deleted the dependencies-and-docs-cleanup branch July 24, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgar-manukyan edgar-manukyan edgar-manukyan approved these changes

@ramiromagno ramiromagno Awaiting requested review from ramiromagno

@rammprasad rammprasad Awaiting requested review from rammprasad

Assignees
No one assigned
Labels
None yet
Projects
sdtm.oak R package
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galachad @edgar-manukyan