Replace base messages with rlang and cli #76
Merged
Task list completed / task-list-completed
Started
2024-07-30 13:02:46
ago
0 / 14 tasks completed
14 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| Replace base message with rlang | Incomplete |
| Move vignette to package space | Incomplete |
| Adds missing metadata in vignette | Incomplete |
| Place Closes #<insert_issue_number> into the beginning of your Pull z | |
| Request Title (Use Edit button in top-right if you need to update) | Incomplete |
| Code is formatted according to the | |
| tidyverse style guide. Run | |
styler::style_file() to style R and Rmd files |
Incomplete |
| Updated relevant unit tests or have written new unit tests, which should | |
| consider realistic data scenarios and edge cases, e.g. empty datasets, errors, | |
| boundary cases etc. - See | |
| Unit Test Guide | Incomplete |
| If you removed/replaced any function and/or function parameters, did you | |
| fully follow the | |
| deprecation guidance? | Incomplete |
| Update to all relevant roxygen headers and examples, including keywords | |
| and families. Refer to the | |
| categorization of functions to tag appropriate keyword/family. | Incomplete |
Run devtools::document() so all .Rd files in the man folder and the |
|
NAMESPACE file in the project root are updated appropriately |
Incomplete |
| Address any updates needed for vignettes and/or templates | Incomplete |
Update NEWS.md if the changes pertain to a user-facing function (i.e. it |
|
has an @export tag) or documentation aimed at users (rather than developers) |
Incomplete |
Build oak site pkgdown::build_site() and check that all affected |
|
| examples are displayed correctly and that all new functions occur on the "Reference" page. | Incomplete |
Address or fix all lintr warnings and errors - lintr::lint_package() |
Incomplete |
Run R CMD check locally and address all errors and warnings - devtools::check() |
Incomplete |
| Link the issue in the Development Section on the right hand side. | Incomplete |
| Address all merge conflicts and resolve appropriately | Incomplete |
| Pat yourself on the back for a job well done! Much love to your accomplishment! | Incomplete |
Can't we stick with cli::cli_abort/warn/inform() all across instead of rlang::abort/warn/inform()? Just for consistency. |
Incomplete |
The S3 registration of mutate.cnd_df is not a mistake by you (it's a commit by me made earlier to this PR, see d6e3d92. So think commit d0873ac should be reverted. |
Incomplete |
Locally, I still get the testthat snapshot blfl related issues when I run devtools::check() on this PR, so I am guessing that the CI/CD checking this PR is not using the latest admiraldev version, is it? |
Incomplete |
Loading