Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching for tests #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VincentBlondeau
Copy link
Member

Disable compiled expression cache during test run. If you change the behavior of the core components, you want the test to be accurate

…behavior of the core components, you want the test to be accurate
@astares
Copy link
Collaborator

astares commented Nov 5, 2024

@VincentBlondeau
I only see you preserving the state between #setUp and #tearDown - but not setting it explicitly to false using #compiledExpressionCacheEnabled:

Do I miss something obvious here or is the PR incomplete?

@astares
Copy link
Collaborator

astares commented Nov 25, 2024

@VincentBlondeau Did you see my comment? Or do you just preserve so that the cache is not changed by a test?

@VincentBlondeau
Copy link
Member Author

Maybe I overlook this part. Feel free to update the PR with this or I'll try to do it at some point. Thanks for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants