Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid analyzing classes in Manifest methods while checking ReClassesHaveNoReferencesCondition #16954

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Avoid analyzing classes in Manifest methods while checking ReClassesHaveNoReferencesCondition #16954

merged 5 commits into from
Jul 31, 2024

Commits on Jul 26, 2024

  1. Avoid checking Manifest classes in ReClassesHaveNoReferencesCondition. 

    Add isManifest method for RB classes.
Add testIsManifest.
Fix failing #testTransform method in RBRemoveProtocolTransformationTest
    Hernán Morales Durand committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8da4f34 View commit details
    Browse the repository at this point in the history

  2. Avoid creating a "mock" package manifest test class because then test… 

    …ManifestNamesAccordingToPackageNames fails
    Hernán Morales Durand committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2717f63 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Merge branch 'pharo-project:Pharo13' into fix_exclude_package_manifes… 

    …t_from_classref_rule
    @hernanmd
    hernanmd authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    41d3d3e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'pharo-project:Pharo13' into fix_exclude_package_manifes… 

    …t_from_classref_rule
    @hernanmd
    hernanmd authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a7bd0ad View commit details
    Browse the repository at this point in the history

  2. Simpler and better implementation of isManifest 

    Check that superclass is not nil, as suggested by @Ducasse.
Add tests
    Hernán Morales Durand committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9d05ffc View commit details
    Browse the repository at this point in the history