Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember package refactor17388 #17414

Merged

Conversation

AlexisCnockaert
Copy link
Collaborator

Fixes: #17388
I created a class variable to remember lastselected package, the next time its searched by default

Screen Shot 2024-11-19 at 11 01 02

Here it is remembered :

Screen Shot 2024-11-19 at 11 01 11

@AlexisCnockaert AlexisCnockaert self-assigned this Nov 19, 2024
@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 19, 2024
@Ducasse
Copy link
Member

Ducasse commented Nov 21, 2024

Pay attention
Instance variable names must start with a lowercase letter: {ClySystemBrowserContext class}

@Ducasse
Copy link
Member

Ducasse commented Nov 21, 2024

Alexis you should use a class variable (sharedVariables: and not an instance variables of the metaclass. Please read the Pharo by example chapter so that you get it right because knowing the difference it important.
There is also a video on the pharo mooc.

@AlexisCnockaert
Copy link
Collaborator Author

Alexis you should use a class variable (sharedVariables: and not an instance variables of the metaclass. Please read the Pharo by example chapter so that you get it right because knowing the difference it important.
There is also a video on the pharo mooc.

Sorry I'll pay attention next time

@Ducasse Ducasse closed this Nov 25, 2024
@Ducasse Ducasse reopened this Nov 25, 2024
@Ducasse Ducasse merged commit 1a37cd2 into pharo-project:Pharo13 Nov 25, 2024
1 of 2 checks passed
@AlexisCnockaert AlexisCnockaert deleted the RememberPackageRefactor17388 branch November 25, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remembering application when moving a method to another package
3 participants