Beautified

phax · Oct 12, 2023 · 99a98e4 · 99a98e4
1 parent 299c2fc
commit 99a98e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/phase4-lib/src/main/java/com/helger/phase4/profile/IAS4Profile.java b/phase4-lib/src/main/java/com/helger/phase4/profile/IAS4Profile.java
@@ -43,8 +43,7 @@ public interface IAS4Profile extends IHasID <String>, IHasDisplayName
   IAS4ProfileValidator getValidator ();
 
   /**
-   * Create a PMode for the provided parameters.<br>
-   * TODO the naming is bad. Should be called <code>createPMode</code>
+   * Create a PMode for the provided parameters.
    *
    * @param sInitiatorID
    *        Initiator ID

diff --git a/phase4-lib/src/main/java/com/helger/phase4/profile/IAS4ProfileValidator.java b/phase4-lib/src/main/java/com/helger/phase4/profile/IAS4ProfileValidator.java
@@ -22,11 +22,13 @@
 import com.helger.phase4.ebms3header.Ebms3SignalMessage;
 import com.helger.phase4.ebms3header.Ebms3UserMessage;
 import com.helger.phase4.model.pmode.IPMode;
+import com.helger.phase4.v3.ChangeV3;
 
 /**
- * Generic profile validator
+ * Generic AS4 profile validator
  *
  * @author bayerlma
+ * @author Philip Helger
  */
 public interface IAS4ProfileValidator
 {
@@ -38,6 +40,7 @@ public interface IAS4ProfileValidator
    * @param aErrorList
    *        The error list to be filled. May not be <code>null</code>.
    */
+  @ChangeV3 ("add parameter if for UserMessage or SignalMessage")
   default void validatePMode (@Nonnull final IPMode aPMode, @Nonnull final ErrorList aErrorList)
   {}
 

diff --git a/phase4-lib/src/main/java/com/helger/phase4/servlet/soap/SOAPHeaderElementProcessorWSS4J.java b/phase4-lib/src/main/java/com/helger/phase4/servlet/soap/SOAPHeaderElementProcessorWSS4J.java
@@ -312,8 +312,8 @@ private ESuccess _verifyAndDecrypt (@Nonnull final Document aSOAPDoc,
        * </pre>
        */
 
-      // TODO we need a way to distinct
-      // signature and decrypt WSSecurityException provides no such thing
+      // TODO we need a way to differentiate signature and decrypt
+      // WSSecurityException provides no such thing
       aErrorList.add (EEbmsError.EBMS_FAILED_DECRYPTION.getAsError (aLocale));
       aState.setSoapWSS4JException (ex);
       return ESuccess.FAILURE;