chore: better robustness for triple control key press detect and disable preference

src/command/KeyBindingManager.js

@@ -75,6 +75,7 @@ define(function (require, exports, module) {
     const _registeredCustomKeyMaps = {};
 
     const STATE_CUSTOM_KEY_MAP_ID = "customKeyMapID";
+    const PREF_TRIPLE_CTRL_KEY_PRESS_ENABLED = "tripleCtrlPalette";
 
     /**
      * @private
@@ -1101,9 +1102,10 @@ define(function (require, exports, module) {
         }
     }
 
-    let lastKeyPressTime = 0; // Store the time of the last key press
+    let lastCtrlKeyPressTime = 0; // Store the time of the last key press
     let pressCount = 0; // Counter for consecutive Control key presses
-    const doublePressInterval = 500; // Maximum time interval between presses, in milliseconds, to consider it a double press
+    const doublePressInterval = 250; // Maximum time interval between presses, in milliseconds, to consider it a double press
+    const PRESS_ACTIVATE_COUNT = 3;
     const ctrlKeyCodes = {
         ControlLeft: true,
         ControlRight: true,
@@ -1113,22 +1115,28 @@ define(function (require, exports, module) {
         Meta: true
     };
     function _detectTripleCtrlKeyPress(event) {
+        if(PreferencesManager && !PreferencesManager.get(PREF_TRIPLE_CTRL_KEY_PRESS_ENABLED)){
+            return false;
+        }
+        const currentTime = new Date().getTime(); // Get the current time
         if (ctrlKeyCodes[event.code] && ctrlKeyCodes[event.key] && !event.shiftKey && !event.altKey) {
-            const currentTime = new Date().getTime(); // Get the current time
             pressCount++;
-            if (currentTime - lastKeyPressTime <= doublePressInterval) {
-                if(pressCount === 3) {
-                    KeyboardOverlayMode.startOverlayMode();
-                    event.stopPropagation();
-                    event.preventDefault();
-                    return true;
-                }
-                // ignore all higher order press events like triple/quadruple press
-            } else {
+            if(pressCount === PRESS_ACTIVATE_COUNT && (currentTime - lastCtrlKeyPressTime) <= doublePressInterval) {
+                KeyboardOverlayMode.startOverlayMode();
+                event.stopPropagation();
+                event.preventDefault();
+                lastCtrlKeyPressTime = currentTime;
+                Metrics.countEvent(Metrics.EVENT_TYPE.KEYBOARD, 'ctrlx'+PRESS_ACTIVATE_COUNT, "showOverlay");
+                return true;
+            }
+            if((currentTime - lastCtrlKeyPressTime) > doublePressInterval){
                 pressCount = 1;
             }
-            lastKeyPressTime = currentTime;
+            lastCtrlKeyPressTime = currentTime;
+        } else {
+            pressCount = 0;
         }
+        return false;
     }
 
     const dontHideMouseOnKeys = {
@@ -1862,6 +1870,9 @@ define(function (require, exports, module) {
                 _loadUserKeyMap();
                 exports.constructor(EVENT_PRESET_CHANGED, _customKeymapIDInUse);
             });
+        PreferencesManager.definePreference(PREF_TRIPLE_CTRL_KEY_PRESS_ENABLED, "boolean", true, {
+            description: Strings.DESCRIPTION_TRIPLE_CTRL_PALETTE
+        });
         _customKeymapIDInUse = PreferencesManager.stateManager.get(STATE_CUSTOM_KEY_MAP_ID);
         _loadUserKeyMap();
     });

src/command/KeyboardOverlayMode.js

@@ -43,7 +43,7 @@ define(function (require, exports, module) {
 
     function showOverlay(targetId) {
         // Find the target div and the overlay div
-        Metrics.countEvent(Metrics.EVENT_TYPE.KEYBOARD, "ctrlx3", "showOverlay");
+        Metrics.countEvent(Metrics.EVENT_TYPE.UI, "palette", "showOverlay");
         if(!targetId){
             console.error("No target ID for selecting overlay. Ignoring");
             return;

src/nls/root/strings.js

@@ -1019,6 +1019,7 @@ define({
     "DESCRIPTION_RULERS_ENABLED": "true to enable editor rulers, else false",
     "DESCRIPTION_AUTO_RENAME_TAGS": "true to automatically rename paired HTML/XML tag, else false",
     "DESCRIPTION_DRAG_AND_DROP_ENABLED": "true to enable drag and drop functionality for files and folders from the file explorer or Finder",
+    "DESCRIPTION_TRIPLE_CTRL_PALETTE": "true to enable showing the visual command overlay on pressing Ctrl/Cmd key 3 consecutive times",
     "DESCRIPTION_SMART_INDENT": "Automatically indent when creating a new block",
     "DESCRIPTION_SOFT_TABS": "false to turn off soft tabs behavior",
     "DESCRIPTION_SORT_DIRECTORIES_FIRST": "true to sort the directories first in the project tree",