Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update SVG files to use viewBox instead of width and height #554

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

atleugim
Copy link
Contributor

πŸ“ About your SVG:

  • Title: Base UI, Dropbox, Lottielab, JSON, and Shiki
  • Category: ...Inherited from the logos
  • Website URL: ...Inherited from the logos
  • Description: These svg files were not using the viewBox attribute but width and height, this fixes that.

Searching in VSCode: <svg(?![^>]*\bviewBox\b)[^>]*>
Also if using the svgomg app (refer to the screenshot)

πŸ“· Screenshots:

Capture-2025-01-30-091314

βœ… Checklist

  • I have permission to use this logo.
  • The .svg file is optimized for web use.
  • The .svg size is less than 20kb.

@pheralb
Copy link
Owner

pheralb commented Jan 30, 2025

Thanks πŸš€βœ¨

I create a utility to add the viewbox property:

pnpm run fix:viewbox

@pheralb pheralb merged commit 1097028 into pheralb:main Jan 30, 2025
2 of 3 checks passed
@atleugim atleugim deleted the fix/logos-viewbox branch January 30, 2025 18:51
@atleugim atleugim restored the fix/logos-viewbox branch January 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants