Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findTransformECC error #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

songheony
Copy link

In some OpenCV library, it is needed to input parameter inputMask and gaussFiltSize for findTransformECC.
I've fixed it following this comment.
And, from official OpenCV Github and the document site, I've set gaussFiltSize as 5.

@timmeinhardt
Copy link
Collaborator

Thank you for your PR but which bug are you referring to? Running the camera compensation works in the current master branch.

@songheony
Copy link
Author

I'm using master branch, and I installed openCV from Anaconda by the following command
conda install -c conda-forge opencv
I think this is due to differences in the environment where the openCV was built.

@timmeinhardt
Copy link
Collaborator

Okay, but I want to keep the repository working with the instructions given in the README.md. So your changes might not work with the OpenCV version recommended in the README.md. I will keep the PR open just in case someone struggles with the same issues but at this point I will not merge it into the main branch.

@songheony
Copy link
Author

songheony commented Jun 30, 2020

I fully agree with your decision. And that's why I used try-except.
People using the proposed version of OpenCV will not get an error with the original code, so the code below (after except) will not be executed.
Anyway, I just want people suffering from issues like me to see this PR and fix the code.

@timmeinhardt
Copy link
Collaborator

I think your issue comes from installing a different opencv version than used in the master branch. Have you tried installing it they way you did but specifying the same version as in our requirements.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants