Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly stop client on Stop #188

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: properly stop client on Stop #188

merged 5 commits into from
Jan 22, 2024

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Dec 13, 2023 •
edited
Loading

This is a attempt to fix the client not closing issue mentioned in #189

@sruehl sruehl mentioned this pull request Dec 13, 2023
Closed
@sruehl
Copy link
Contributor Author

sruehl commented Dec 13, 2023 •
edited
Loading

At the moment the added test would run with the unchanged code in client, which is due the client setting the state immediately on master

@sruehl sruehl marked this pull request as ready for review January 5, 2024 10:39
@sruehl sruehl marked this pull request as draft January 5, 2024 10:44
@sruehl sruehl marked this pull request as ready for review January 5, 2024 11:00
@philippseith
Copy link
Owner

Can you please change the usage of partyBase.wgin client to party.waitGroup()? Then I will merge the PR

@sruehl
Copy link
Contributor Author

sruehl commented Jan 18, 2024

updated. Please double check if I understood you right because I changed c.wg.Add... to c.partyBase.waitGroup().Add. I could not find a reference to party so I implied you meant this by that.

@philippseith philippseith merged commit 84c9a53 into philippseith:master Jan 22, 2024
5 of 6 checks passed
@sruehl sruehl deleted the fix/properly_stopping branch January 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sruehl @philippseith