-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for web transports #191
Conversation
Nice! |
At the moment I'm in the process of verification, hence the PR is still in draft. I'll update here once I know that it works |
@@ -126,7 +127,14 @@ func NewHTTPConnection(ctx context.Context, address string, options ...func(*htt | |||
var conn Connection | |||
switch { | |||
case negotiateResponse.hasTransport("WebTransports"): | |||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way the way I noticed btw as this lead to a nasty nil pointer at a completely unrelated place (connection nil and error nil at the same time).
Also I wonder if we should merge it in this state and fix potential issues later or temporary return a proper error on master? |
And regarding the failing Unit test. I have no idea what is going on there... |
@philippseith I prepared a PR for option 2 #192. |
seems that Unit test failure is unrelated to this PR and is caused by 35b4977 |
a4070cd
to
6aa9891
Compare
I rebased this on #192 |
This PR should no be safe to merge as it fixes two issues:
|
resolves #190
resolves #193