Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ReceiveFunc for client. #73 #205

Closed
wants to merge 1 commit into from

Conversation

umaYnit
Copy link

@umaYnit umaYnit commented Oct 28, 2024

Add ReceiveFunc for client, use method map in base receiver, to support the methods that cannot be named in Go.

@philippseith
Copy link
Owner

philippseith commented Nov 3, 2024

Thank you for bringing up this requirement. I understand that it can be necessary to define alternate names for hub or receiver functions if the other parties API cannot be changed. Likewise we should not change the API of this package by changing the ReceiverInterface. Please look at #206. Does this serve your needs?

BTW I don't think this is the same as #73 and I am still curious how to fulfill #73 in a general way. Maybe with generics?

@umaYnit
Copy link
Author

umaYnit commented Nov 6, 2024

Thank you for your reply. #206 is my needs. I modified the ReceiverInterface because I’m not familiar with the SignalR and don’t quite understand the relationship between receiver, hub, and party.

@philippseith
Copy link
Owner

Solved by #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants