-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests of autoprocessing #5
base: master
Are you sure you want to change the base?
Add tests of autoprocessing #5
Conversation
Using Github Actions to run Notes:
TODO
|
p = autoscrub._agnostic_Popen( | ||
["autoscrub", "autoprocess", "--debug", input, output] | ||
) | ||
_, stderr = autoscrub._agnostic_communicate(p) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #2 in which processing continued indefinitely, a timeout is essential here, akin to subprocess.Popen.communicate
. @philipstarkey, is this something that could/should be added to autoscrub._agnostic_communicate
or should I be using something else. here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I've set a timeout on the test runner, using pytest-timeout
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but the test is stalling on Windows at this point (both locally and on Python 2.7 and 3.8).
Tests
autoscrub autoprocess
command (by calling the CLI) on example_screencast.mp4, a file previously used for benchmarking and troubleshooting.