Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component for all IRIs from IRIMappedIndex #121

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

b-gehrke
Copy link
Contributor

Previously, index_remove and index_take removed only the components for the first IRI in a component from an IRIMappedIndex index.

@phillord
Copy link
Owner

Looks find to me. Can you squash the formatting changes ?

@b-gehrke
Copy link
Contributor Author

Sure, done.

@phillord
Copy link
Owner

Feel free to merge to devel

Copy link
Collaborator

@filippodebortoli filippodebortoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in control flow are OK, but there is some unnecessary cloning happening. I marked the lines where this could be avoided.

src/ontology/iri_mapped.rs Outdated Show resolved Hide resolved
src/ontology/iri_mapped.rs Outdated Show resolved Hide resolved
src/ontology/iri_mapped.rs Outdated Show resolved Hide resolved
@filippodebortoli filippodebortoli added enhancement New feature or request API This concerns horned as a library refactor labels Nov 15, 2024
@filippodebortoli filippodebortoli merged commit 71b16a8 into phillord:devel Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This concerns horned as a library enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants