Further scorelog cleanup #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta2-1
force-pushed
the
cleanup_scorelog
branch
from
7d27e58 to
4bc3a1a
Compare
Current coverage is 90.37% (diff: 100%)
@@ cleanup_scorelog #1 diff @@
==================================================
Files 481 481
Lines 26897 26894 -3
Methods 0 0
Messages 0 0
Branches 0 0
==================================================
- Hits 24309 24306 -3
Misses 2588 2588
Partials 0 0
|
| if not isinstance(score["user"], models.Model): | ||
| score["user_id"] = score["user"] | ||
| del score["user"] | ||
| if 'action_code' in score and score['user_id'] is not None: |
There was a problem hiding this comment.
@ta2-1 in my testing sometimes the user was a real user object - in these cases it saves sql to pass it through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.