Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new hook for dataset features (modifying model datasets after they are populated, but before dataset-scaling for
pblum_mode='dataset-scaled'
and before any cost function is computed).This also starts on a more general framework to simplify defining new features. Right now it is still necessary to manually create the parameter-creation function as well as the allowed kinds (in
parameters/feature.py
) but shows how this can be defined in the feature class itself.Eventually we may want to allow for creating these at runtime, but that will require additional thought on how these would be sent to a remote server and also should think about other cases where a user may want to write custom functionality outside of phoebe, and so is intentionally deferred here.
TODO: