Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Features #891

Draft
wants to merge 3 commits into
base: release-2.5
Choose a base branch
from
Draft

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jun 11, 2024

This PR implements a new hook for dataset features (modifying model datasets after they are populated, but before dataset-scaling for pblum_mode='dataset-scaled' and before any cost function is computed).

This also starts on a more general framework to simplify defining new features. Right now it is still necessary to manually create the parameter-creation function as well as the allowed kinds (in parameters/feature.py) but shows how this can be defined in the feature class itself.

Eventually we may want to allow for creating these at runtime, but that will require additional thought on how these would be sent to a remote server and also should think about other cases where a user may want to write custom functionality outside of phoebe, and so is intentionally deferred here.

TODO:

  • make sure the GPs have sufficient test coverage and pass tests here since the logic has been moved
  • test coverage for the sinusoidal third light (or hide from users and instead keep just as an example for future development)

@kecnry kecnry mentioned this pull request Jun 13, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant