🐧🐛 Issue #167: Clearing cache on Android device is ineffective

plugin.xml

@@ -20,6 +20,7 @@
         <param name="android-package" value="com.adobe.phonegap.contentsync.Sync"/>
       </feature>
     </config-file>
+    <framework src="com.android.support:support-v4:23+"/>
     <source-file src="src/android/Sync.java" target-dir="src/com/adobe/phonegap/contentsync"/>
   </platform>
   <platform name="browser">
@@ -90,4 +91,4 @@
     </config-file>
     <framework src="libz.dylib"/>
   </platform>
-</plugin>
+</plugin>

src/android/Sync.java

@@ -63,6 +63,7 @@
 import android.net.Uri;
 import android.os.Environment;
 import android.os.StatFs;
+import android.support.v4.content.ContextCompat;
 import android.util.Log;
 import android.util.Patterns;
 import android.webkit.CookieManager;
@@ -431,6 +432,7 @@ private void sync(final JSONArray args, final CallbackContext callbackContext) t
             copyCordovaAssets = args.getBoolean(4);
         }
         final String manifestFile = args.getString(8);
+        final boolean backup = args.getBoolean(10);
         Log.d(LOG_TAG, "sync called with id = " + id + " and src = " + src + "!");
 
         final ProgressEvent progress = createProgressEvent(id);
@@ -453,7 +455,7 @@ public void run() {
                     }
                 }
 
-                String outputDirectory = getOutputDirectory(id);
+                String outputDirectory = getOutputDirectory(id, backup);
 
                 // Check to see if we should just return the cached version
                 String type = args.optString(2, TYPE_REPLACE);
@@ -607,9 +609,14 @@ private boolean isZipFile(File targetFile) {
         return success;
     }
 
-    private String getOutputDirectory(final String id) {
+    private String getOutputDirectory(final String id, boolean backup) {
         // Production
-        String outputDirectory = cordova.getActivity().getFilesDir().getAbsolutePath();
+        String outputDirectory = null;
+        if (backup) {
+            outputDirectory = cordova.getActivity().getFilesDir().getAbsolutePath();
+        } else {
+            outputDirectory = ContextCompat.getNoBackupFilesDir(cordova.getActivity()).getAbsolutePath();
+        }
         // Testing
         //String outputDirectory = cordova.getActivity().getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS).getAbsolutePath();
         outputDirectory += outputDirectory.endsWith(File.separator) ? "" : File.separator;

www/index.js

@@ -78,13 +78,17 @@ var ContentSync = function(options) {
     }
 
     if (typeof options.manifest === 'undefined') {
-        options.manifest = "";
+        options.manifest = '';
     }
 
     if (typeof options.validateSrc === 'undefined') {
         options.validateSrc = true;
     }
 
+    if (typeof options.backup === 'undefined') {
+        options.backup = false;
+    }
+
     // store the options to this object instance
     this.options = options;
 
@@ -106,7 +110,7 @@ var ContentSync = function(options) {
 
     // wait at least one process tick to allow event subscriptions
     setTimeout(function() {
-        exec(success, fail, 'Sync', 'sync', [options.src, options.id, options.type, options.headers, options.copyCordovaAssets, options.copyRootApp, options.timeout, options.trustHost, options.manifest, options.validateSrc]);
+        exec(success, fail, 'Sync', 'sync', [options.src, options.id, options.type, options.headers, options.copyCordovaAssets, options.copyRootApp, options.timeout, options.trustHost, options.manifest, options.validateSrc, options.backup]);
     }, 10);
 };
 
@@ -228,11 +232,11 @@ module.exports = {
         var callback = (typeof headers == "function" ? headers : cb);
         exec(callback, callback, 'Sync', 'download', [url, null, headers]);
     },
-    
+
     /**
      * loadUrl
      *
-     * This method allows loading file:// urls when using WKWebViews on iOS. 
+     * This method allows loading file:// urls when using WKWebViews on iOS.
      *
      */