Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating phonon-supercell files in velph #18

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

atztogo
Copy link
Contributor

@atztogo atztogo commented Aug 29, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (79725c8) to head (6a82b55).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/phelel/velph/cli/utils.py 0.00% 11 Missing ⚠️
src/phelel/velph/cli/supercell/generate.py 11.11% 8 Missing ⚠️
src/phelel/velph/cli/phono3py/init.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    73.42%   73.51%   +0.08%     
===========================================
  Files           74       74              
  Lines         5223     5233      +10     
===========================================
+ Hits          3835     3847      +12     
+ Misses        1388     1386       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit 22d9939 into develop Aug 29, 2024
2 checks passed
@atztogo atztogo deleted the phonon-supercell branch August 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants