Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add velph-phonopy command #45

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add velph-phonopy command #45

merged 4 commits into from
Dec 9, 2024

Conversation

atztogo
Copy link
Contributor

@atztogo atztogo commented Dec 9, 2024

Having this command, [phono3py.phonon] support was dropped.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 67.75701% with 69 lines in your changes missing coverage. Please review.

Project coverage is 72.78%. Comparing base (3159f2e) to head (007daed).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
src/phelel/velph/cli/init/init.py 68.91% 23 Missing ⚠️
src/phelel/velph/cli/phonopy/__init__.py 55.55% 16 Missing ⚠️
src/phelel/velph/cli/phonopy/init.py 72.00% 14 Missing ⚠️
src/phelel/velph/cli/phonopy/generate.py 46.66% 8 Missing ⚠️
src/phelel/velph/cli/phono3py/__init__.py 0.00% 5 Missing ⚠️
src/phelel/velph/cli/phono3py/init.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    73.21%   72.78%   -0.44%     
===========================================
  Files           77       81       +4     
  Lines         5500     5647     +147     
===========================================
+ Hits          4027     4110      +83     
- Misses        1473     1537      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit fd0662e into develop Dec 9, 2024
5 checks passed
@atztogo atztogo deleted the velph-phonopy branch December 9, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants