Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit conversion #191

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Fix unit conversion #191

merged 7 commits into from
Nov 20, 2023

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Nov 19, 2023

Unit conversion was property performed for non-VASP calculators. This PR attempts to fix it.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a12cfe0) 62.09% compared to head (3d50a56) 61.91%.

❗ Current head 3d50a56 differs from pull request most recent head ed39f74. Consider uploading reports for the commit ed39f74 to get more accurate results

Files Patch % Lines
phono3py/cui/create_force_constants.py 55.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
- Coverage    62.09%   61.91%   -0.19%     
===========================================
  Files           70       70              
  Lines        12482    12493      +11     
===========================================
- Hits          7751     7735      -16     
- Misses        4731     4758      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit a543a6b into develop Nov 20, 2023
11 checks passed
@atztogo atztogo deleted the fix-unit-conversion branch November 20, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant