Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to migrate build system to nanobind, scikit-build-core, and cmake #247

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Jul 7, 2024

This is an attempt to migrate the phono3py build system for using nanobind, scikit-build-core, and cmake like phonopy/phonopy#383.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.57%. Comparing base (a981a04) to head (5df6b5b).
Report is 8 commits behind head on develop.

Files Patch % Lines
cmake-format.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    65.66%   65.57%   -0.09%     
===========================================
  Files           72       73       +1     
  Lines        12817    12831      +14     
===========================================
- Hits          8416     8414       -2     
- Misses        4401     4417      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit d52aae6 into develop Jul 8, 2024
12 of 13 checks passed
@atztogo atztogo changed the title [WIP] Attempt to migrate build system to nanobind, scikit-build-core, and cmake Attempt to migrate build system to nanobind, scikit-build-core, and cmake Jul 8, 2024
@atztogo atztogo deleted the nanobind branch July 8, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant