BUGFIX: Fix crashing bug when embeded file changed while in --watch mode
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbontwelve
changed the title
--watch mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug raised in #33 by swapping out usage of
EleventyRenderPlugin.RenderManagerforEleventyRenderPlugin.Stringwhich is the exported template render function.EleventyRenderPlugin.RenderManagerignores thetemplateConfigvalue passed to it, instead choosing to use its own internal state. When 11ty runs in--watchmode that internal state becomes different to what 11ty provides via itseleventy.configevent. This is likely because the interlinker plugin is usingRenderManagerin a way its not intended to be used.Fortunatly the compile function that
RenderManager.compilewraps is also exported, however oddly named asString. This PR replaces usage of the render manager with usage of that compile function and should fix the crashing bug reported in #33.