Improvements thanks to Scrutinizer

photogabble · Sep 20, 2021 · 3b97d6b · 3b97d6b
1 parent 5abfe8f
commit 3b97d6b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/classes/Db.php b/classes/Db.php
@@ -69,7 +69,6 @@ public function initAdodb(): object
             $db_host .= ":$db_port";
         }
 
-        $old_db = new \stdClass();
         // Attempt to connect to the database
         try
         {
@@ -107,6 +106,7 @@ public function initAdodb(): object
             throw new \Exception($err_msg);
         }
 
+        $old_db->prefix = null;
         $old_db->prefix = $db_prefix;
         // End of database work
         return $old_db;

diff --git a/classes/KabalHunt.php b/classes/KabalHunt.php
@@ -29,7 +29,6 @@ class KabalHunt
     public static function hunt(\PDO $pdo_db, string $lang, array $playerinfo, int $kabalisdead, Registry $tkireg): void
     {
         $langvars = Translate::load($pdo_db, $lang, array('main'));
-        $targetinfo = array();
 
         $sql = "SELECT COUNT(*) AS num_players FROM ::prefix::ships WHERE ship_destroyed='N' AND email NOT LIKE '%@kabal' AND ship_id > 1";
         $stmt = $pdo_db->prepare($sql);

diff --git a/classes/KabalToPlanet.php b/classes/KabalToPlanet.php
@@ -352,7 +352,7 @@ public static function planet(\PDO $pdo_db, string $lang, int $planet_id, Regist
             $shiplist = $stmt->fetchAll(\PDO::FETCH_ASSOC);
             $i = 0;
 
-            if (is_array($shiplist))
+            if ($shiplist !== false)
             {
                 foreach ($shiplist as $onplanet)
                 {