fix: make it possible to inject http client into factories #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
fix-http-client-factory
branch
from
44abd56 to
7d8613f
Compare
OskarStark
reviewed
Dec 8, 2024
| public static function create(#[\SensitiveParameter] string $apiKey, string $version = '2023-06-01'): Platform | ||
| { | ||
| $responseHandler = new ModelHandler(new EventSourceHttpClient(), $apiKey, $version); | ||
| public static function create( |
There was a problem hiding this comment.
Why not using a withHttpClient() method?
There was a problem hiding this comment.
As a separate method? What's the benefit?
There was a problem hiding this comment.
You can instantiate it and change it later, maybe because you want to inject a traceable http client later + you could return a clone to stay immutable, but just an idea and maybe not needed
There was a problem hiding this comment.
yes, that was basically the motivation here - to use the factory in the bundle but use the traceable one instantiated by the framework already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.