feat: introduce optional fault tolerant toolbox #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have mixed feelings about the solution, I would rather throw a dedicated event and let the user chose the solution, WDYT? We can also add something to the docs about it |
chr-hertel
force-pushed
the
fix-unknown-tool
branch
2 times, most recently
from
eaf6fc6 to
d39021d
Compare
|
Okay okay okay :D - couldn't wrap my head around an event tho and went with decoration - also cleaner i guess :) needed to decouple the exceptions more for that, but i think that's no harm |
chr-hertel
changed the title
chr-hertel
force-pushed
the
fix-unknown-tool
branch
3 times, most recently
from
eae6dfa to
9a2b755
Compare
|
With a fast review it looks good, let's merge it |
OskarStark
approved these changes
Feb 15, 2025
chr-hertel
force-pushed
the
fix-unknown-tool
branch
from
9a2b755 to
57bad21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea is to feedback to the llm that the used tool is not available and try again.
had that a few times now.
[BC BREAK] Change of toolbox exception namespaces