Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: swtich to ramsey composer action with matrix #4

Merged
merged 2 commits into from
Sep 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,23 @@ on: pull_request
jobs:
pipeline:
runs-on: ubuntu-latest
strategy:
matrix:
php: ['8.2', '8.3']
dependencies: ['lowest', 'highest']
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
php-version: ${{ matrix.php }}

- name: Cache Vendors
uses: actions/cache@v4
id: cache-vendors
- name: Install Composer
uses: "ramsey/composer-install@v3"
with:
path: vendor
key: ${{ runner.os }}-vendor-${{ hashFiles('**/composer.lock') }}
dependency-versions: "${{ matrix.dependencies }}"

- name: Composer Validation
run: composer validate --strict
Expand Down
2 changes: 1 addition & 1 deletion src/Store/ChromaDb/Store.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function addDocuments(array $documents): void
$this->logger->warning('Document {id} does not have a vector', ['id' => $document->id]);
}

$ids[] = $document->id->toString();
$ids[] = (string) $document->id;
$vectors[] = $document->vector->getData();
$metadata[] = $document->metadata->getArrayCopy();
}
Expand Down