-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: from vendor to structural namespaces for models and platforms #68
Conversation
The discovery for versions is much worse imho 😟 |
For the bigger picture of supporting more combinations of Provider / Model it looks like an idea. Even it is something very abstract currently for me to see how this improve the library for the future but when looking at the linked pages ... yeah. Good idea. But why then the namespace |
There is still autocomplete/discovery possible. You don't have to choose between different
It's referring to the Interfaces at first level ( |
Thanks for the feedback guys 🙏 |
Maybe as a last addition, my goal would be to bring the ease of using different models, like those platforms (replicate, huggingface, etc) provide, to this lib... |
eb8eca5
to
bbd9afc
Compare
What I meant with the version class discovery is, that if I end up with one version class containing sonnet and gpt4o for example, what prevents me to setup my LLM Platform OpenAI with Sonnet? |
That's not the case here. I switched from additional Version VO to plain string constants in the corresponding model |
And also before that the string was not validated and I could have entered whatever in the version object |
Ok 👍🏻 But now one can (like before) only use a new model when updating the lib 😟 |
That would be a show stopper, true, but i can still use |
Hmm, right, i can't indicate the capabilities of the model with Image, Tool or structured output Support ... 🤔 |
Bottom line: good point 😆 👍 |
What about dedicated model classes which know if they support a platform? You know what I mean? I am currently on a phone an cannot provide a code example |
Yup, same here - not really at my desk today. Still thinking tho about the different characteristics per model.
For the first two items we can provide some helpers, like DX gimmicks, but shouldn't be too strict since validation and change scenarios are not ours. |
bbd9afc
to
0c12cd1
Compare
With #140 there is a new |
0c12cd1
to
d706360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto Pull Request Review from LlamaPReview
Large PR Notification
Dear contributor,
Thank you for your substantial contribution to this project. LlamaPReview has detected that this Pull Request contains a large volume of changes, which exceeds our current processing capacity.
Details:
- PR and related contents total size: Approximately 69,298 characters
- Current limit: 50,000 characters
Next steps:
- Consider breaking this PR into smaller, more focused changes if possible.
- For manual review, please reach out to your team members or maintainers.
We appreciate your understanding and commitment to improving this project. Your contributions are valuable, and we want to ensure they receive the attention they deserve.
LlamaPReview is continuously evolving to better serve the community. Share your thoughts on handling large PRs in our GitHub Discussions - your feedback helps us improve and expand our capabilities.
If you have any questions or need assistance, our community and support team are here to help.
Best regards,
LlamaPReview Team
based on the listings of azure, ollama or huggingface the libraries structure/namespaces will scale better over time when not using vendor names like
Anthropic
orOpenAI
as top level namespaces, but rather structural ones likePlatform
andModel
.I decided against having a tree like structure but splitting into those two namespaces, since it is more like a matrix when looking at some providers supporting multiple different llms.
i'm aware that this will cause larger pain on downstream dependents and might combine it with a further refactoring of
Document
,Message
andResponse
classes