feat: introduce message metadata and traits (#91) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
feature-message-metadata
branch
2 times, most recently
from
9945404 to
9a86adc
Compare
chr-hertel
changed the title
|
TBH I am not sure I like this 😄 |
|
Me neither. What is your concern about? |
|
Imagine i would want that UID in all messages, i would need to extend all messages to do so. Custom Systemmessage, CustomAssistantMessage, etc... or when using metadata the data would rather be unstructured |
|
And that wouldn't be sufficient since processors, like the Tool one, add built in messages without UID. But other than UID it could be the actual User reference, additional information about the tool call, like used source documents or links |
chr-hertel
force-pushed
the
feature-message-metadata
branch
2 times, most recently
from
e8efe71 to
0834aad
Compare
chr-hertel
force-pushed
the
feature-message-metadata
branch
from
0834aad to
57be246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple ideas around Message - started by
didn't that anything yet and just a draft ...