Add support for Symfony 6 #179
Conversation
Remove SF 3.4 as it is EOL'd as of November 2021 and no longer receives updates (https://symfony.com/releases/3.4)
|
@andig Any chance of getting this PR in for SF6 support too? 🙏 |
| @@ -6,15 +6,15 @@ | |||
| use Symfony\Component\Config\Loader\LoaderInterface; | |||
| use Symfony\Component\Config\Resource\FileResource; | |||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | |||
| use Symfony\Component\Routing\RouteCollectionBuilder; | |||
| use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator; | |||
There was a problem hiding this comment.
Does this work for all Symfony versions?
There was a problem hiding this comment.
From 4.X onward, yes I believe so. I figured since this is only used in the tests it would be OK to update it.
|
|
||
| class Kernel extends \Symfony\Component\HttpKernel\Kernel | ||
| { | ||
| use MicroKernelTrait; | ||
|
|
||
| const CONFIG_EXTS = '.{php,xml,yaml,yml}'; | ||
|
|
||
| public function registerBundles() |
There was a problem hiding this comment.
Does this change the php version?
There was a problem hiding this comment.
The neyt line‘s signature, sorry
There was a problem hiding this comment.
Hmm, I think these would need PHP 7.4? Again: as these were in the tests I worked on the basis that this should be OK. I was running against PHP 8 at the time. I can revert the changes but it's becoming increasingly difficult to have PHP <7.4 and PHP8 code in the same lib. SF6 adds return types to many classes which would then break these anyway so??? What would you prefer to do?
There was a problem hiding this comment.
I wouldn't know. But I agree- as these are only the tests it should be ok. Upgrading minimum php version would be a separate PR then.
There was a problem hiding this comment.
I would personally recommend the minimum PHP version be 7.4 since 7.3 is unsupported and does not receive security updates.
I do have some additional updates for ppm just not got around to making PRs for them yet. I don't mind adding that if it works for you guys?
| @@ -4,14 +4,14 @@ | |||
| "license": "MIT", | |||
| "require": { | |||
| "php-pm/php-pm": "^2.0", | |||
| "symfony/http-foundation": "^3.4|^4.2.12|^5.0", | |||
| "symfony/http-kernel": "^3.4|^4.0|^5.0", | |||
| "symfony/http-foundation": "^4.2.12|^5.0|^6.0", | |||
There was a problem hiding this comment.
I am not sure - it was there before, so I left it "as-is". Maybe there is a security issue with versions below 4.2.12?
There was a problem hiding this comment.
I was just notified of GHSA-754h-5r27-7x3r. We should upgrade to ^4.1.13|^5.1.5. I'm not sure if this version constraint can properly be handled?
I'd be happy for follow-up PR.
There was a problem hiding this comment.
Sure! I'll make a new PR with just that suggested change and see if it works out. Technically SF <5.3 is no longer supported and 5.3 drops out the end of this month. I am not sure how much of an issue that restraint is in the grand scheme of things based on that?
There was a problem hiding this comment.
Then lets just upgrade to a then-supported version
There was a problem hiding this comment.
#180 - with a comment about suggested versions.
Remove SF 3.4 as it is EOL'd as of November 2021 and no longer receives updates (https://symfony.com/releases/3.4)