Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature signals #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature signals #12

wants to merge 3 commits into from

Conversation

AydinHassan
Copy link
Member

Allow attaching to system signals.

  • Add a default handler for resizing and refresh the terminal size.
  • Implement non blocking stream reading so we don't block on fread and therefore signal handlers will be executed.
  • Upgrade phpstan and fix some issues

@mikeymike I know this is old but do you remember what you wanted to do with this before finishing it?

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #12 into master will decrease coverage by 6.94%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
- Coverage     80.74%   73.79%   -6.95%     
- Complexity       85       98      +13     
============================================
  Files             7        8       +1     
  Lines           161      187      +26     
============================================
+ Hits            130      138       +8     
- Misses           31       49      +18
Impacted Files Coverage Δ Complexity Δ
src/IO/BufferedOutput.php 81.81% <ø> (ø) 5 <0> (ø) ⬇️
src/IO/NonBlockingResourceInputStream.php 0% <0%> (ø) 3 <3> (?)
src/IO/ResourceInputStream.php 84.61% <100%> (+1.28%) 8 <6> (+1) ⬆️
src/IO/ResourceOutputStream.php 83.33% <100%> (+1.51%) 8 <6> (+1) ⬆️
src/InputCharacter.php 100% <100%> (ø) 12 <0> (ø) ⬇️
src/NonCanonicalReader.php 90.47% <66.66%> (-4.27%) 11 <4> (+2)
src/UnixTerminal.php 64.21% <68.42%> (-5.79%) 49 <8> (+6)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725f86c...30e5a50. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants