Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cassette Name Check Condition #40

Closed
wants to merge 4 commits into from
Closed

Update Cassette Name Check Condition #40

wants to merge 4 commits into from

Conversation

ivancli
Copy link

@ivancli ivancli commented Jul 31, 2022

This PR is to fix the deprecation warning in #39

@specialtactics
Copy link

I'm struggling to figure out why this would be a problem - there is an empty check right above that code.

@ivancli ivancli changed the title Add cassette null check before substr Update Cassette Name Check Condition Aug 20, 2022
@ivancli
Copy link
Author

ivancli commented Aug 20, 2022

I'm struggling to figure out why this would be a problem - there is an empty check right above that code.

I've cleaned up the code a bit to also check for null now.

PHP8.1 shows a warning when the $cassetteName is null which the check couldn't catch.

@ivancli ivancli closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivancli @specialtactics