Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused headers from link.c #16080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused headers from link.c #16080

wants to merge 1 commit into from

Conversation

jorgsowa
Copy link
Contributor

Removes unused headers from link.c. Initially, I wanted to remove just ctype.h, but found others that are also unused.

@jorgsowa jorgsowa requested a review from bukka as a code owner September 26, 2024 22:31
cmb69
cmb69 reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Apparently, this has been overlooked for a long time; win32/pwd.h is removed as of PHP 5.2.0.

@jorgsowa jorgsowa force-pushed the remove-unused-headers-link branch from f0ca8aa to 11cdcc3 Compare October 13, 2024 17:38
@jorgsowa
Copy link
Contributor Author

I will take care of other places also.

@jorgsowa jorgsowa force-pushed the remove-unused-headers-link branch from 11cdcc3 to 618c81f Compare January 15, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgsowa @cmb69