Mark tests using port 64324 as conflicting #16871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternatively, we could choose another port, but that likely will conflict with some other test in the future. The proper solution would be to use ephemeral ports[1], but our OpenSSL `ServerClientTestCase` does not support this yet. [1] <php@6ab4e33>
|
Why not just change one of them to a port number that's still free? |
|
I find it tedious to search for a free port (and if users do in-tree builds of external extensions, we can't even know), but I don't mind which workaround we apply. 64327 doesn't look to be in use by the rest of the test suite, so used this. |
nielsdos
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, we could choose another port, but that likely will conflict with some other test in the future. The proper solution would be to use ephemeral ports[1], but our OpenSSL
ServerClientTestCasedoes not support this yet.[1] 6ab4e33
In the long run, we should probably unify the different test servers anyway.
PS: found via https://github.com/php/php-src/actions/runs/11925029888/job/33236457305