Fixed GH-17398: bcmul memory leak #17615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freed regardless of the refcount.
nielsdos
requested changes
Jan 29, 2025
ext/bcmath/libbcmath/src/init.c
Outdated
| *num = NULL; | ||
| } | ||
|
|
||
| void bc_force_free_numbers(void) |
There was a problem hiding this comment.
During GSHUTDOWN you should use the passed bcmath_globals instead of BCG to avoid freeing the wrong data in ZTS. In fact, If I were you I'd call _bc_force_free_number directly in GSHUTDOWN.
ext/bcmath/libbcmath/src/init.c
Outdated
| @@ -82,6 +82,20 @@ void bc_init_numbers(void) | |||
| BCG(_two_)->n_value[0] = 2; | |||
| } | |||
|
|
|||
| static void _bc_force_free_number(bc_num *num) | |||
There was a problem hiding this comment.
Function names starting with underscores should be avoided in new code because in C a name starting with underscore is reserved.
SakiTakamachi
changed the title
BCG release processing of PHP_GSHUTDOWN_FUNCTION()
|
@nielsdos |
nielsdos
approved these changes
Jan 29, 2025
SakiTakamachi
added a commit
that referenced
this pull request
Jan 29, 2025
The deleted line has returned, so delete it again.
SakiTakamachi
added a commit
that referenced
this pull request
Jan 29, 2025
* PHP-8.4: follow up for #17615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take2 of #17594